PWGLF: Remove V0Datas tables from cascadePreselector processes in the cascadebuilder#6295
Merged
Merged
Conversation
Collaborator
|
Hi @creetz16 , indeed, I think this is a great idea and it would be useful to merge this - thanks a lot! Thanks also for testing. :-D No objections to carrying on from my side. |
Contributor
Author
|
Cool! Thanks a lot @ddobrigk :) |
creetz16
requested review from
BongHwi,
ChiaraDeMartin95,
alibuild,
chiarapinto,
ercolessi,
fmazzasc,
mbombara,
njacazio and
skundu692
as code owners
njacazio
approved these changes
May 27, 2024
Collaborator
|
Thanks @creetz16 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ddobrigk :)
Would it be possible to add these changes to the cascadebuilder? They would allow to run the cascadebuilder with the KF without having to run the lambdakzerobuilder to produce the V0Datas tables.
As far as I see, the aod::V0Datas subscriptions in the cascadePreselector processes are not necessary. I ran some tests locally to make sure and everything looks fine so far. Am I overlooking something or could we indeed remove those subscriptions?